chore: Extract some tied down logic#3374
Merged
Merged
Conversation
# Conflicts: # native/core/src/execution/shuffle/mod.rs
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3374 +/- ##
============================================
+ Coverage 56.12% 60.03% +3.90%
- Complexity 976 1475 +499
============================================
Files 119 175 +56
Lines 11743 16179 +4436
Branches 2251 2686 +435
============================================
+ Hits 6591 9713 +3122
- Misses 4012 5112 +1100
- Partials 1140 1354 +214 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Towards #3354
Rationale for this change
Starts separating code so moving the partitioners out of the shuffle_writer file will not look like a mess.
What changes are included in this PR?
Moved metrics into a separate file.
Renamed the struct ShufflePartitionerMetrics, there is some inconsistent use of "partitioner" and "repartitioner" throughout the module, I think partitioner fits better since we only deal from the context of a single partition at all times, and regardless of which variation is chosen I think it's better to make everything uniform.
Moved the function that aligns the scratch space with the current buffered batches into the ScratchSpace struct itself, it seems very logical due to the function signature and its actual logic.
Did this mostly because it moves out a big chunk of code that was "stuck" inside the partitioner logic itself, which will make changes there look a bit messy.
How are these changes tested?
By the usual tests, as there is no change in logic.